-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated SCMS Files #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has this always failed all CI checks?
I don't think so. These appear to be failing due to the removal of the ASN files from source control. |
…nto 1609dot2/transition-to-etsi-v2.1.1
…nto 1609dot2/transition-to-etsi-v2.1.1
This has been updated with the latest changes from #21 & re-deployed to the dev & test clusters. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Asn1_Codec runs and functions as expected when running normal payloads through it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! Runs correctly locally + tests are passing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Changes
The purpose of the changes in this PR is to transition the ACM away from utilizing the 'scms-asn1' git submodule, opting instead to directly include the updated SCMS files within the project.
Git Submodule Changes
The 'scms-asn1' git submodule has been removed.
Updated SCMS Files
The SCMS files that were being used before were from 2018. These files are from 2021/2022 and include the following:
The 'Ieee1609Dot2.asn' file depends on a structure defined in the 'EtsiTs103097ExtensionModule.asn' file.
Testing
Dependent PR
This PR depends on the changes made in the following PRs and should be merged after.